[Core] Warn when --temp-dir is given on a worker node ray start
#31294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
scv119
approved these changes
Dec 26, 2022
scv119
added
the
@author-action-required
|
Nice improvemence! |
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
Signed-off-by: SangBin Cho <rkooo567@gmail.com> Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SangBin Cho rkooo567@gmail.com
Why are these changes needed?
When we start a node we can specify --temp-dir but it only works if the node is the head node. This PR prints the warning to users that temp-dir is ignored.
Alternatively we could raise an exception. I am open to this option too, but it'd be great to minimize the upgrade friction.
Related issue number
Closes #28876
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.