-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Chaining sub-models in RLModules with dynamic spec keys inside forward methods ("Solution 1") #31310
Closed
ArturNiederfahrenhorst
wants to merge
30
commits into
ray-project:master
from
ArturNiederfahrenhorst:ModelIO
Closed
[RLlib] Chaining sub-models in RLModules with dynamic spec keys inside forward methods ("Solution 1") #31310
ArturNiederfahrenhorst
wants to merge
30
commits into
ray-project:master
from
ArturNiederfahrenhorst:ModelIO
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
ArturNiederfahrenhorst
changed the title
[RLlib] ModelIO
[RLlib] ModelIO for basic models
Dec 23, 2022
ArturNiederfahrenhorst
changed the title
[RLlib] ModelIO for basic models
[RLlib] Chaining sub-models in RLModules with dynamic spec keys inside forward methods ("Solution 1")
Dec 23, 2022
ArturNiederfahrenhorst
requested review from
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
December 27, 2022 13:28
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
7 tasks
Closed because we are going with something that is closer to #31469 , and so I'll work from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Link to Solution 2
As discussed via Slack, we need to match the future ModelCatalog, the Models and RLModule in the sense of where to define specs and keys for these specs, and also what information to use when calling a model inside an RLModule.
"Solution 1" has some advantages:
This PR introduces "Solution #1", with the addition of ModelIOMapping, which dynamically creates distinct IO keys for different sub-models. It therefore avoids much of the information leakage of implementation detail from keys used in input specs of these models.
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.