[Serve] Return 400 response code for malformed Serve configs sent via REST API #31379
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
| @@ -115,8 +115,15 @@ async def delete_serve_application(self, req: Request) -> Response: | |||
| async def put_all_deployments(self, req: Request) -> Response: | |||
| from ray.serve.schema import ServeApplicationSchema | |||
| from ray.serve._private.api import serve_start | |||
| from pydantic import ValidationError | |||
There was a problem hiding this comment.
I delayed the pydantic import, so it doesn't become a dependency for the dashboard.
| except ValidationError as e: | ||
| return Response( | ||
| status=400, | ||
| text=repr(e), |
There was a problem hiding this comment.
I used repr instead of str since str sometimes fails for Unicode exceptions (see this StackOverflow thread for more info).
sihanwang41
approved these changes
Jan 3, 2023
zcin
approved these changes
Jan 3, 2023
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
… REST API (#31379) When users submit a malformed Serve config (e.g. with invalid fields) via `PUT` request, they receive a 500 error. This change makes the REST API return a 400 (unretryable) error instead.
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
… REST API (ray-project#31379) When users submit a malformed Serve config (e.g. with invalid fields) via `PUT` request, they receive a 500 error. This change makes the REST API return a 400 (unretryable) error instead. Signed-off-by: tmynn <hovhannes.tamoyan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shreyas Krishnaswamy shrekris@anyscale.com
Why are these changes needed?
When users submit a malformed Serve config (e.g. with invalid fields) via
PUTrequest, they receive a 500 error. This change makes the REST API return a 400 (unretryable) error instead.Related issue number
Closes #31370
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.test_serve_agent.py.