Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][Bug Fix] Do not start the http server if include_dashboard is False. #31666

Conversation

rkooo567
Copy link
Contributor

Signed-off-by: SangBin Cho rkooo567@gmail.com

Why are these changes needed?

Currently, when the include_dashboard is False, there are 2 issues.

  1. From the output of ray.init & ray start, we still prints the dashboard URL.
  2. Although we properly disabled all the modules, we start the HTTP server (which means users can still access the UI although it doesn't work).

This PR fixes both issues.

Related issue number

Closes #31465

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: SangBin Cho <rkooo567@gmail.com>
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
Signed-off-by: SangBin Cho <rkooo567@gmail.com>
@rkooo567 rkooo567 changed the title [WIP] Do not start the http server if include_dashboard is False. [Core][Bug Fix] Do not start the http server if include_dashboard is False. Jan 19, 2023
Copy link
Contributor

@rickyyx rickyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there is some failures though?


via GIPHY

@@ -166,6 +170,11 @@ async def run(self):
"If nothing is specified, all modules are loaded."
),
)
parser.add_argument(
"--disable-frontend",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should we keep the argument name consistent with serve_frontend? e.g. no-serve-frontend?

@rkooo567 rkooo567 merged commit c694dae into ray-project:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ray start script setting --include-dashboard=false does not work
2 participants