-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish the new IA for dashboard #31770
Conversation
Signed-off-by: Alan Guo <aguo@anyscale.com>
Hmm do we only separate out actors from the job page? What about task / pg table? |
I asked the same question to Huaiwei. Yes, this is expected for now. We separate out actors table because we believe that it is an important data people want to be able to find more easily. |
It was probably my fault and I probably didn't communicate it clearly enough. I think we should keep actor table in both places
|
Signed-off-by: Alan Guo <aguo@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about other tables then? Is there a reason why we only consider actor table in a special way?
Test failures seem relevant |
I guess my criterion on when to add a tab for something is:
If you think other tables meet this, we should consider creating tabs for them. Placement group: I don't think that people will look at them alone? We could either keep it as a separate section. Or it could be grouped under "scheduler and autoscaler" section? |
I see. Tasks: Yes, I think it should be with progress bar. |
Btw I am not merging it because the windows failure is related |
Signed-off-by: Alan Guo <aguo@anyscale.com>
Signed-off-by: Alan Guo <aguo@anyscale.com>
Ready to merge! |
Signed-off-by: Alan Guo aguo@anyscale.com
Why are these changes needed?
Update to more closely match the design spec.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.