Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the new IA for dashboard #31770

Merged
merged 5 commits into from
Jan 23, 2023
Merged

Conversation

alanwguo
Copy link
Contributor

Signed-off-by: Alan Guo aguo@anyscale.com

Why are these changes needed?

Update to more closely match the design spec.

Screenshot 2023-01-18 at 5 57 33 PM

Screenshot 2023-01-18 at 5 57 39 PM

Screenshot 2023-01-18 at 6 00 10 PM

  1. Update nav bar styles
  2. Move actors table for job to actors page in job details
  3. Made cards responsive for narrow screens
  4. Made metrics charts match style of overview cards
  5. Update Icon for collapsible section
  6. Various visual polish throughout app

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Alan Guo <aguo@anyscale.com>
@rkooo567
Copy link
Contributor

Hmm do we only separate out actors from the job page? What about task / pg table?

@alanwguo
Copy link
Contributor Author

Hmm do we only separate out actors from the job page? What about task / pg table?

I asked the same question to Huaiwei. Yes, this is expected for now. We separate out actors table because we believe that it is an important data people want to be able to find more easily.

@scottsun94
Copy link
Contributor

Hmm do we only separate out actors from the job page? What about task / pg table?

I asked the same question to Huaiwei. Yes, this is expected for now. We separate out actors table because we believe that it is an important data people want to be able to find more easily.

It was probably my fault and I probably didn't communicate it clearly enough. I think we should keep actor table in both places

  • job -> charts page (people could see all types of info like actor info, task info together)
  • job -> actors page (as Alan said, people are able to find them more easily compared to scrolling down to find it within the charts page)

Signed-off-by: Alan Guo <aguo@anyscale.com>
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about other tables then? Is there a reason why we only consider actor table in a special way?

@rkooo567
Copy link
Contributor

Test failures seem relevant

@scottsun94
Copy link
Contributor

scottsun94 commented Jan 19, 2023

What about other tables then? Is there a reason why we only consider actor table in a special way?

I guess my criterion on when to add a tab for something is:

  • add tabs when the info is frequently used alone and users don’t want to click several times on the chart page to find it.

If you think other tables meet this, we should consider creating tabs for them.

Placement group: I don't think that people will look at them alone? We could either keep it as a separate section. Or it could be grouped under "scheduler and autoscaler" section?
Task: I guess people need to look at progress bar or timeline view with the task table together? It doesn't make sense to have a separate tab for tasks?

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 20, 2023
@rkooo567
Copy link
Contributor

I see.

Tasks: Yes, I think it should be with progress bar.
Pg: Yes, I think it should be used with actor / task table. I think the best UX is actually the pg scheduling status is embedded into task/actor table.

@rkooo567
Copy link
Contributor

Btw I am not merging it because the windows failure is related

Signed-off-by: Alan Guo <aguo@anyscale.com>
Signed-off-by: Alan Guo <aguo@anyscale.com>
@alanwguo alanwguo removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 21, 2023
@alanwguo
Copy link
Contributor Author

Ready to merge!

@rkooo567 rkooo567 merged commit cdb3780 into ray-project:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants