[RLlib] Add tags option to actor manager #31803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avnish <avnishnarayan@gmail.com>
avnishn
requested review from
sven1977,
gjoliver,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
gjoliver
reviewed
Jan 20, 2023
Signed-off-by: Avnish <avnishnarayan@gmail.com>
Signed-off-by: Avnish <avnishnarayan@gmail.com>
gjoliver
reviewed
Jan 30, 2023
Signed-off-by: Avnish <avnishnarayan@gmail.com>
Signed-off-by: Avnish <avnishnarayan@gmail.com>
gjoliver
reviewed
Jan 30, 2023
rllib/utils/actor_manager.py
Outdated
| @@ -599,6 +605,7 @@ def foreach_actor( | |||
| def foreach_actor_async( | |||
| self, | |||
| func: Union[Callable[[Any], Any], List[Callable[[Any], Any]]], | |||
| tag: str = "default", | |||
There was a problem hiding this comment.
so thinking about this a bit more, it would be the best if we can attach multiple tags to an async all, like basically this parameter should be tags:
for sync alls, tags would be ()
for async call users, they can attached multiple tags for a single call, like ("rollout_worker", "sync_weight")
for async fetch result, we can also specify a single, or list of tags. for example, ("eval", "sample") will fetch all the sample() calls on eval workers.
I understand this is back & forth a few times, not sure if you are interested in making the changes.
if not, we can merge and unblock. you for now, and I can make these updates later today.
There was a problem hiding this comment.
actually can I add a todo here and we punt on this?
There was a problem hiding this comment.
We need this pr to implement the async trainer runner and I am falling behind atm
There was a problem hiding this comment.
I've added a todo as a comment for now
Signed-off-by: Avnish <avnishnarayan@gmail.com>
Signed-off-by: Avnish <avnishnarayan@gmail.com>
gjoliver
approved these changes
Feb 2, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Avnish <avnishnarayan@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Avnish avnishnarayan@gmail.com
Add named tags for actor manager async requests.
that way async requests can be grouped and requested together.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.