Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][core] Fix state api large scale test log prefix mismath #31865

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jan 23, 2023

Signed-off-by: rickyyx rickyx@anyscale.com

Why are these changes needed?

we added job id in the log prefix in #31772, breaking the test.

This fixes the test to reflect the change.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx changed the title [core] Fix state api large scale test log prefix mismath [ci][core] Fix state api large scale test log prefix mismath Jan 23, 2023
@rkooo567 rkooo567 merged commit 3b09a54 into ray-project:master Jan 23, 2023
@rkooo567
Copy link
Contributor

Looks like release test still failed to run (URL not available error). Since I merged it, can you just run it against master?

@rickyyx
Copy link
Contributor Author

rickyyx commented Jan 23, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants