[docs] simple web crawler example #31900
Conversation
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
| "In this example we'll quickly demonstrate how to build a simple web scraper in Python and\n", | ||
| "parallelize it with Ray Tasks with minimal code changes.\n", | ||
| "\n", | ||
| "To run this example locally on your machine, please first install `ray` and `beautifulsoup` with\n", |
There was a problem hiding this comment.
let's also specify the version you tested against?
| "outputs": [ | ||
| { | ||
| "name": "stdout", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "CPU times: user 19.3 s, sys: 340 ms, total: 19.7 s\n", | ||
| "Wall time: 25.8 s\n" | ||
| ] | ||
| }, | ||
| { |
There was a problem hiding this comment.
somehow when this renders, it looks like code, so it'd be nice if we can differentiate somehow...
There was a problem hiding this comment.
yes, good point. I made the output bold for now. We can iterate on that.
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
There was a problem hiding this comment.
Nice, this looks great!
The ecosystem gallery looks a little bit misaligned (e.g. it would probably be better if all the github stars were at the bottom and the logos be a little more aligned) :)
Also for the use case gallery, the logos are sometimes a little bit too close to the top.
The content of the new example looks great!
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
maxpumperla
requested review from
gjoliver,
krfricke,
xwjiang2010,
amogkam,
matthewdeng and
Yard1
as code owners
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
|
tests not passing? |
Signed-off-by: Max Pumperla <max.pumperla@googlemail.com>
|
@richardliaw should be good now, let's see. |
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
We want to continue building more, and more easily accessible examples on our docs. This PR starts that initiative by also setting up the testing harness, so that we can just add more notebooks. No particular reason to start with a crawler, just turned out to be a quick one. We'll work on more relevant examples, like @richardliaw 's AIR example wish list in as a follow-up.