[data] New executor [10/n]--- Plumbing for locality_with_output and setting execution options #31908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
Signed-off-by: Eric Liang <ekhliang@gmail.com>
ericl
requested review from
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
Signed-off-by: Eric Liang <ekhliang@gmail.com>
c21
approved these changes
Jan 25, 2023
| from ray.data._internal.execution.legacy_compat import ( | ||
| execute_to_legacy_block_iterator, | ||
| ) | ||
|
|
||
| executor = StreamingExecutor(ExecutionOptions()) | ||
| executor = StreamingExecutor(copy.deepcopy(ctx.execution_options)) |
There was a problem hiding this comment.
given execution_options could be muted in StreamingExecutor/BulkExecutor, shall we just provide a method in DatasetContext.get_execution_options() to just return a deep copy of ctx.execution_options?
There was a problem hiding this comment.
Missed this comment--- I'll file a followup.
jianoaix
approved these changes
Jan 25, 2023
| @@ -171,6 +175,8 @@ def __init__( | |||
| self.enable_auto_log_stats = enable_auto_log_stats | |||
| self.trace_allocations = trace_allocations | |||
| self.optimizer_enabled = optimizer_enabled | |||
| # TODO: expose execution options in Dataset public APIs. | |||
There was a problem hiding this comment.
It'd be better to create a tracking issue
jianoaix
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?