[RLlib] Fixed the autorom dependency issue #31933
Conversation
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Co-authored-by: Cade Daniel <edacih@gmail.com> Signed-off-by: kourosh hakhamaneshi <31483498+kouroshHakha@users.noreply.github.com>
| # AutoROM downloads ROMs via torrent when they are built. The torrent is unreliable, | ||
| # so we built it for py3 and use that instead. This wheel was tested for python 3.7, 3.8, | ||
| # and 3.9. | ||
| - https://ray-ci-deps-wheels.s3.us-west-2.amazonaws.com/AutoROM.accept_rom_license-0.5.4-py3-none-any.whl |
There was a problem hiding this comment.
one thing, do we need to also install autorom? can't remember if this installs autorom or just the actual ROMs..
There was a problem hiding this comment.
This should be sufficient. Let's see if the release tests pass now on ci.
|
@cadedaniel Do we know why the other test have not started yet? Can we increase the available compute for the release tests? |
We need more data point :) |
|
Oh, I thought you only specified one run. Hmm capacity yeah.. did you run with high priority? I think this should be high priority given that it's hard to get signal from many release tests until this is fixed |
Oh I didn't set the priority. running it again. :( |
|
How long should it take with high priority? it's still not staring the tests? |
|
Not sure, perhaps it is simply next in line? We might miss the nightly run tonight, it's OK. |
|
@cadedaniel I don't understand why these tests are still pending? should we just merge without proper testing? |
|
Cc @krfricke do you know why the tests are still pending? Maybe we should just merge.. |
|
@cadedaniel I think we should merge. The failures are the known ones. @ArturNiederfahrenhorst has a PR #31910 would most likely bring down the flakiness of Impala tests. |
|
Sounds good! LGTM |
In #31933 we fix an Atari ROM dependency that by default uses a torrent to download ROMs. The tests in this PR also break occasionally due to the same reason. I moved the ROM dependency to S3 to increase reliability. I actually think we can remove the ROM dependency from these app configs since I don't see any RL test using them. But I think that is too much risk for this PR, since it will likely end up as a cherry pick to 2.3.
Co-authored-by: Cade Daniel <edacih@gmail.com> Closes ray-project#31880 Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
In ray-project#31933 we fix an Atari ROM dependency that by default uses a torrent to download ROMs. The tests in this PR also break occasionally due to the same reason. I moved the ROM dependency to S3 to increase reliability. I actually think we can remove the ROM dependency from these app configs since I don't see any RL test using them. But I think that is too much risk for this PR, since it will likely end up as a cherry pick to 2.3. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Kourosh Hakhamaneshi kourosh@anyscale.com
Why are these changes needed?
Closes #31880
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.