Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] Save and restore stateful callbacks as part of experiment checkpoint #31957

Merged
merged 15 commits into from
Feb 1, 2023

Commits on Jan 26, 2023

  1. Add Restorable interface

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    884df77 View commit details
    Browse the repository at this point in the history
  2. Make callback restorable

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    5a54410 View commit details
    Browse the repository at this point in the history
  3. Add unit tests for callback save/restore

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    5cd27e3 View commit details
    Browse the repository at this point in the history
  4. Save/restore callback state automatically in Tune loop

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    4f72660 View commit details
    Browse the repository at this point in the history
  5. Fix lint

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    3f018d0 View commit details
    Browse the repository at this point in the history
  6. Add unit test for trial runner callback save/resume

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    15d2f8b View commit details
    Browse the repository at this point in the history
  7. Add docstrings (with help from chatgpt)

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    91a1872 View commit details
    Browse the repository at this point in the history
  8. Add to bazel build file

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    b751897 View commit details
    Browse the repository at this point in the history
  9. Fix tests failing

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    7fc6db9 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Fix entrypoint for test_callbacks

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    563cfc9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3ac7c9b View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Remove restorable interface

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    c1a07d2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    52ac0db View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Don't allow users to save individual callbacks, only the full list

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    97197e2 View commit details
    Browse the repository at this point in the history
  2. Remove irrelevant tests

    Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
    justinvyu committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    1dd2d52 View commit details
    Browse the repository at this point in the history