Revert "[core] Fix gcs healthch manager crash when node is removed by node manager." #31995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishbone
approved these changes
Jan 28, 2023
clarng
pushed a commit
to clarng/ray
that referenced
this pull request
Jan 31, 2023
…moved by node manager."" (ray-project#32019) This reverts commit 51c5eda. Reverts ray-project#31995 Skip the windows test. Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
… node manager. (ray-project#31917)" (ray-project#31995) This reverts commit a32b9b1. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…moved by node manager."" (ray-project#32019) This reverts commit 51c5eda. Reverts ray-project#31995 Skip the windows test. Signed-off-by: Yi Cheng <74173148+iycheng@users.noreply.github.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #31917
Broke the build on windows
cc @iycheng @scv119