[core] Add generic __ray_ready__ method to Actor classes
#31997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Fricke <kai@anyscale.com>
ericl
added
the
core-interface-change-approval-required
Signed-off-by: Kai Fricke <kai@anyscale.com>
ericl
approved these changes
Jan 28, 2023
jjyao
reviewed
Jan 30, 2023
|
@jjyao |
pcmoritz
approved these changes
Jan 30, 2023
clarng
pushed a commit
to clarng/ray
that referenced
this pull request
Jan 31, 2023
…ct#31997) We currently have no canonical way to await actors. Users can define their own _is-ready_ methods, schedule a future, and await these, but this has to be done for every actor class separately. This does not match other patterns - e.g. we have `actor.__ray_terminate__.remote()` for actor termination and `placement_group.ready()` for placement group ready futures. This PR adds a new `__ray_ready__` magic actor method that just returns `True`. It can be used to await actors becoming ready (newly scheduled actors), and actors having processed all of their other enqueued tasks. Signed-off-by: Kai Fricke <kai@anyscale.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…ct#31997) We currently have no canonical way to await actors. Users can define their own _is-ready_ methods, schedule a future, and await these, but this has to be done for every actor class separately. This does not match other patterns - e.g. we have `actor.__ray_terminate__.remote()` for actor termination and `placement_group.ready()` for placement group ready futures. This PR adds a new `__ray_ready__` magic actor method that just returns `True`. It can be used to await actors becoming ready (newly scheduled actors), and actors having processed all of their other enqueued tasks. Signed-off-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kai Fricke kai@anyscale.com
Why are these changes needed?
We currently have no canonical way to await actors. Users can define their own is-ready methods, schedule a future, and await these, but this has to be done for every actor class separately.
This does not match other patterns - e.g. we have
actor.__ray_terminate__.remote()for actor termination andplacement_group.ready()for placement group ready futures.This PR adds a new
__ray_ready__magic actor method that just returnsTrue. It can be used to await actors becoming ready (newly scheduled actors), and actors having processed all of their other enqueued tasks.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.