[core][state] Adjust worker side reporting with batches && add debugstring (remerging #31840) #32057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orker-side-batching
…orker-side-batching
Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
… TA-worker-side-batching
… TA-worker-side-batching
rickyyx
commented
Jan 30, 2023
Comment on lines
+141
to
+143
| size_t num_to_send = | ||
| std::min(static_cast<size_t>(RayConfig::instance().task_events_send_batch_size()), | ||
| static_cast<size_t>(buffer_.size())); |
There was a problem hiding this comment.
Adding casting explicitly to make it work on macOS
rickyyx
added
the
tests-ok
|
Release test also passing: https://buildkite.com/ray-project/release-tests-pr/builds/26884 |
|
The PR title seems to be wrong |
rkooo567
approved these changes
Jan 31, 2023
rickyyx
changed the title
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…tring (remerging ray-project#31840) (ray-project#32057) Remerging ray-project#31840 Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Remerging #31840
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.