Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][job] Move test_cli_integration to large test #32171

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Feb 1, 2023

Signed-off-by: rickyyx rickyx@anyscale.com

Why are these changes needed?

image

This has caused flaky test failures which are false positives.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
Copy link
Contributor

@architkulkarni architkulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@architkulkarni
Copy link
Contributor

@architkulkarni
Copy link
Contributor

K8s operator test is flaky on master and unrelated.

@architkulkarni architkulkarni added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Feb 2, 2023
@architkulkarni architkulkarni merged commit a954ab7 into ray-project:master Feb 2, 2023
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
This has caused flaky test failures which are false positives.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants