-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Update CMake to support Mac OS X 10.14 #3218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test FAILed. |
|
Test PASSed. |
|
Test PASSed. |
|
Test FAILed. |
|
Test FAILed. |
|
Test PASSed. |
|
Compilation failing on Travis with |
|
Test PASSed. |
|
Test PASSed. |
|
Test PASSed. |
| # Since 10.14, the XCode toolchain only accepts libc++ as the | ||
| # standard library. This should also work on macOS starting from 10.9. | ||
| set(pyarrow_ENV ${pyarrow_ENV} "CXXFLAGS='-stdlib=libc++'") | ||
| set(pyarrow_ENV ${pyarrow_ENV} "MACOSX_DEPLOYMENT_TARGET=10.7") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pcmoritz I'm getting the following error, unless I change 10.7 to 10.14 here. Any idea why?
cmake -DPYTHON_EXECUTABLE=/Users/haochen/.pyenv/versions/3.6.5/bin/python -DPYARROW_BUILD_PARQUET=on -DPYARROW_BOOST_USE_SHARED=on -DPYARROW_BUILD_PLASMA=on -DPYARROW_USE_TENSORFLOW=on -DPYARROW_BUNDLE_ARROW_CPP
=ON -DCMAKE_BUILD_TYPE=release /Users/haochen/code/ant_ray/build/external/arrow/src/arrow_ep/python
error: $MACOSX_DEPLOYMENT_TARGET mismatch: now "10.7" but "10.14" during configure
I'm on macOS 10.14.
What do these changes do?
On Mac OS 10.14, pyarrow doesn't compile unless we pass
-stdlib=libc++as cflags into it. I suspect this change should work as far back as 10.9, but that should be tested.Related issue number
#3210