Skip to content

Conversation

@pcmoritz
Copy link
Contributor

@pcmoritz pcmoritz commented Nov 3, 2018

What do these changes do?

On Mac OS 10.14, pyarrow doesn't compile unless we pass -stdlib=libc++ as cflags into it. I suspect this change should work as far back as 10.9, but that should be tested.

Related issue number

#3210

@pcmoritz pcmoritz changed the title Update CMake to support Mac OS X 10.14 [WIP] Update CMake to support Mac OS X 10.14 Nov 3, 2018
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9025/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9024/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9027/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9028/
Test FAILed.

@pcmoritz pcmoritz changed the title [WIP] Update CMake to support Mac OS X 10.14 Update CMake to support Mac OS X 10.14 Nov 3, 2018
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9037/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9035/
Test PASSed.

@robertnishihara
Copy link
Collaborator

Compilation failing on Travis with

-- Running cmake for pyarrow
cmake -DPYTHON_EXECUTABLE=/Users/travis/miniconda/bin/python  -DPYARROW_BUILD_PARQUET=on -DPYARROW_BOOST_USE_SHARED=on -DPYARROW_BUILD_PLASMA=on -DPYARROW_USE_TENSORFLOW=on -DPYARROW_BUNDLE_ARROW_CPP=ON -DCMAKE_BUILD_TYPE=release /Users/travis/build/ray-project/ray/build/external/arrow/src/arrow_ep/python
[ 37%] �[32m�[1mLinking CXX static library liblocal_scheduler_client.a�[0m
[ 37%] Built target local_scheduler_client
�[35m�[1mScanning dependencies of target ray_objlib�[0m
-- The C compiler identification is AppleClang 9.1.0.9020039
-- The CXX compiler identification is AppleClang 9.1.0.9020039
-- Check for working C compiler: /Applications/Xcode-9.4.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode-9.4.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Applications/Xcode-9.4.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
[ 38%] �[32mBuilding CXX object src/ray/CMakeFiles/ray_objlib.dir/id.cc.o�[0m
-- Check for working CXX compiler: /Applications/Xcode-9.4.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -- broken
CMake Error at /Users/travis/miniconda/lib/python2.7/site-packages/cmake/data/CMake.app/Contents/share/cmake-3.12/Modules/CMakeTestCXXCompiler.cmake:45 (message):
  The C++ compiler

    "/Applications/Xcode-9.4.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++"

  is not able to compile a simple test program.

  It fails with the following output:

    Change Dir: /Users/travis/build/ray-project/ray/build/external/arrow/src/arrow_ep/python/build/temp.macosx-10.6-x86_64-2.7/CMakeFiles/CMakeTmp
    
    Run Build Command:"/usr/bin/make" "cmTC_54a33/fast"
    /Applications/Xcode-9.4.1.app/Contents/Developer/usr/bin/make -f CMakeFiles/cmTC_54a33.dir/build.make CMakeFiles/cmTC_54a33.dir/build
    Building CXX object CMakeFiles/cmTC_54a33.dir/testCXXCompiler.cxx.o
    /Applications/Xcode-9.4.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++    '-stdlib=libc++'  -isysroot /Applications/Xcode-9.4.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.6   -o CMakeFiles/cmTC_54a33.dir/testCXXCompiler.cxx.o -c /Users/travis/build/ray-project/ray/build/external/arrow/src/arrow_ep/python/build/temp.macosx-10.6-x86_64-2.7/CMakeFiles/CMakeTmp/testCXXCompiler.cxx
    clang: error: invalid deployment target for -stdlib=libc++ (requires OS X 10.7 or later)
    make[4]: *** [CMakeFiles/cmTC_54a33.dir/testCXXCompiler.cxx.o] Error 1
    make[3]: *** [cmTC_54a33/fast] Error 2

  CMake will not be able to correctly generate this project.
Call Stack (most recent call first):
  CMakeLists.txt:25 (project)

-- Configuring incomplete, errors occurred!

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9036/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9038/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/9041/
Test PASSed.

@robertnishihara robertnishihara merged commit 99bac44 into ray-project:master Nov 5, 2018
@robertnishihara robertnishihara deleted the fix-macos-10-14 branch November 5, 2018 00:33
williamma12 pushed a commit to williamma12/ray that referenced this pull request Nov 7, 2018
# Since 10.14, the XCode toolchain only accepts libc++ as the
# standard library. This should also work on macOS starting from 10.9.
set(pyarrow_ENV ${pyarrow_ENV} "CXXFLAGS='-stdlib=libc++'")
set(pyarrow_ENV ${pyarrow_ENV} "MACOSX_DEPLOYMENT_TARGET=10.7")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcmoritz I'm getting the following error, unless I change 10.7 to 10.14 here. Any idea why?

cmake -DPYTHON_EXECUTABLE=/Users/haochen/.pyenv/versions/3.6.5/bin/python  -DPYARROW_BUILD_PARQUET=on -DPYARROW_BOOST_USE_SHARED=on -DPYARROW_BUILD_PLASMA=on -DPYARROW_USE_TENSORFLOW=on -DPYARROW_BUNDLE_ARROW_CPP
=ON -DCMAKE_BUILD_TYPE=release /Users/haochen/code/ant_ray/build/external/arrow/src/arrow_ep/python
error: $MACOSX_DEPLOYMENT_TARGET mismatch: now "10.7" but "10.14" during configure

I'm on macOS 10.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants