Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add tips of writing fault tolerant Ray applications #32191

Merged
merged 5 commits into from
Feb 8, 2023

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Feb 2, 2023

Signed-off-by: Jiajun Yao jeromeyjj@gmail.com

Why are these changes needed?

Add tips of writing fault tolerant Ray applications

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

jjyao added 3 commits February 2, 2023 20:28
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
How to Write Fault Tolerant Ray Applications
--------------------------------------------

There are several recommendations to make Ray applications fault tolerant:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything else you'd like to add @stephanie-wang ?

@jjyao jjyao marked this pull request as ready for review February 2, 2023 17:18
@jjyao jjyao requested a review from a team as a code owner February 2, 2023 17:18
Copy link
Contributor

@stephanie-wang stephanie-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some comments for polish.

doc/source/ray-core/doc_code/fault_tolerance_tips.py Outdated Show resolved Hide resolved
doc/source/ray-core/doc_code/fault_tolerance_tips.py Outdated Show resolved Hide resolved
doc/source/ray-core/fault-tolerance.rst Outdated Show resolved Hide resolved
doc/source/ray-core/fault-tolerance.rst Outdated Show resolved Hide resolved
doc/source/ray-core/doc_code/fault_tolerance_tips.py Outdated Show resolved Hide resolved
doc/source/ray-core/fault-tolerance.rst Outdated Show resolved Hide resolved
doc/source/ray-core/fault-tolerance.rst Outdated Show resolved Hide resolved
doc/source/ray-core/fault-tolerance.rst Outdated Show resolved Hide resolved
@stephanie-wang stephanie-wang added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 3, 2023
@jjyao jjyao requested a review from stephanie-wang February 7, 2023 22:16
@jjyao jjyao removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 7, 2023
@stephanie-wang stephanie-wang added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 8, 2023
@stephanie-wang
Copy link
Contributor

Not sure if the doc failure is related.

@jjyao
Copy link
Collaborator Author

jjyao commented Feb 8, 2023

The doc failure is unrelated.

@jjyao jjyao removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 8, 2023
@jjyao jjyao merged commit d256508 into ray-project:master Feb 8, 2023
@jjyao jjyao deleted the jjyao/tips branch February 8, 2023 17:11
jjyao added a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
jjyao added a commit that referenced this pull request Feb 11, 2023
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…t#32191)

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants