Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Update oom docs to reflect latest policy #32219

Merged
merged 11 commits into from
Feb 9, 2023
Merged

[core] Update oom docs to reflect latest policy #32219

merged 11 commits into from
Feb 9, 2023

Conversation

clarng
Copy link
Contributor

@clarng clarng commented Feb 4, 2023 •
edited
Loading

Signed-off-by: Clarence Ng clarence@anyscale.com

Why are these changes needed?

Refresh docs to reflect latest oom killer status

  • remove beta tag
  • create dedicated section on how to disable the feature
  • remove task retry knob, as it is infinite retry by default
  • update worker killer policy section to reflect the new default policy
  • made exponential backoff description a little more clear
  • updated example code to demonstrate the new policy

Related issue number

#32194

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

clarence-wu and others added 4 commits February 3, 2023 19:40
@clarence-wu
oom docs
2f24ba6 
Signed-off-by: Clarence Ng <clarence@anyscale.com>
@clarng
[core] Refresh oom killer docs to reflect latest policy, remove beta …
fae78bf 
…status

Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
@clarng
[core] Refresh oom killer docs to reflect latest policy, remove beta …
dc206c2 
…status

Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
@clarng
Merge branch 'master' of https://github.com/ray-project/ray into oomdocs
205d874 
Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
@clarng clarng marked this pull request as ready for review February 5, 2023 03:41
@clarng clarng requested a review from a team as a code owner February 5, 2023 03:41
clarng and others added 2 commits February 7, 2023 15:09
@clarng @rkooo567
Update doc/source/ray-core/scheduling/ray-oom-prevention.rst
0468824 
Co-authored-by: SangBin Cho <rkooo567@gmail.com>
Signed-off-by: clarng <clarence.wyng@gmail.com>
@clarng @rkooo567
Update doc/source/ray-core/scheduling/ray-oom-prevention.rst
8e56da5 
Co-authored-by: SangBin Cho <rkooo567@gmail.com>
Signed-off-by: clarng <clarence.wyng@gmail.com>
@clarng clarng changed the title oom docs Update doc/source/ray-core/scheduling/ray-oom-prevention.rst to reflect latest policy Feb 8, 2023
@clarng clarng changed the title Update doc/source/ray-core/scheduling/ray-oom-prevention.rst to reflect latest policy Update oom docs to reflect latest policy Feb 8, 2023
@clarng clarng changed the title Update oom docs to reflect latest policy [core] Update oom docs to reflect latest policy Feb 8, 2023
clarng added 2 commits February 8, 2023 00:01
@clarng
[core] Update oom docs to reflect latest policy
474db52 
Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
@clarng
Merge branch 'master' of https://github.com/ray-project/ray into oomdocs
f22164b 
Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
@clarng
Copy link
Contributor Author

clarng commented Feb 8, 2023

gentle ping for doc review @ericl @stephanie-wang

@ericl
Copy link
Contributor

ericl commented Feb 9, 2023

LGTM, but just one question on the intention of mentioning actors.

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 9, 2023
@clarng clarng removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 9, 2023
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 9, 2023
clarng added 3 commits February 8, 2023 16:59
@clarng
[core] Update oom docs to reflect latest policy
89ec1e5 
Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
@clarng
Merge branch 'master' of https://github.com/ray-project/ray into oomdocs
2aa4ad2 
Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
@clarng
[core] Update oom docs to reflect latest policy
4a84d0f 
Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
@clarng clarng removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 9, 2023
@ericl ericl merged commit 5f0f95a into ray-project:master Feb 9, 2023
@clarng clarng mentioned this pull request Feb 10, 2023
Merged
6 tasks
clarng added a commit that referenced this pull request Feb 10, 2023
@clarng
[core] Update oom docs to reflect latest policy (#32219)
9376ebc 
Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
cadedaniel pushed a commit that referenced this pull request Feb 10, 2023
@clarng
[core] Update oom docs to reflect latest policy (#32219) (#32424)
b5a6f88 
Signed-off-by: Clarence Ng <clarence.wyng@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@clarng @edoakes
[core] Update oom docs to reflect latest policy (ray-project#32219)
14bf921 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 left review comments

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

@scv119 scv119

@stephanie-wang stephanie-wang

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clarng @ericl @rkooo567 @scv119 @stephanie-wang @clarence-wu