[tune/train] clean up tune/train result output #32234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
xwjiang2010
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
xwjiang2010
changed the title
xwjiang2010
commented
Feb 9, 2023
| @@ -634,7 +634,6 @@ def check_train_results(train_results: PartialAlgorithmConfigDict) -> ResultDict | |||
| "episode_reward_max", | |||
| "episode_reward_mean", | |||
| "episode_reward_min", | |||
| "episodes_total", | |||
There was a problem hiding this comment.
These two are not populated by rllib anymore.
We probably should just remove them from Tune as well. They are over-indexing to rl, and rl is not even using them anymore..
Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com>
krfricke
approved these changes
Feb 10, 2023
Comment on lines
+21
to
+22
| TIMESTAMP = "timestamp" | ||
| TIME_THIS_ITER_S = "time_this_iter_s" |
There was a problem hiding this comment.
If they need to be consistent, can we just import them from tune?
There was a problem hiding this comment.
yeah makes sense, but can we do that after this? #32260
There was a problem hiding this comment.
Also added a TODO
krfricke
added
the
@author-action-required
xwjiang2010
added
tests-ok
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
* [tune/train] remove duplicated keys in tune/train results. Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * timestamp Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * result_timestamp defaults to None Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * fix test Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * fix progress_reporter test. Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * .get(, None) Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * fix test Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * fix test_gpu Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> * WORKER_ Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> --------- Signed-off-by: xwjiang2010 <xwjiang2010@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xwjiang2010 xwjiang2010@gmail.com
Clean up some results reported by tune/train.
timestampandtime_this_iter_sfrom train should triumph tune.warmup_time, which is not very useful and not mentioned anywhere in our doc.Why are these changes needed?
Related issue number
Closes #32111
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.