-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Restructure core API docs #32236
Merged
Merged
Changes from 23 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
749c8f8
Restructure core API docs
jjyao 9cdfc3e
up
jjyao 8e31911
up
jjyao 9ad9ada
up
jjyao b81b9aa
up
jjyao 55ac49e
up
jjyao 175a824
up
jjyao b34a733
up
jjyao 9286053
up
jjyao f84e755
up
jjyao d97a2d3
up
jjyao fe9d1db
up
jjyao 31903e3
up
jjyao bf86626
up
jjyao 298de25
up
jjyao aaa5f00
up
jjyao 0771fcf
up
jjyao f8cbdc8
up
jjyao 7aa8d6f
up
jjyao 9239df9
up
jjyao 96ae8cf
Revert "up"
jjyao d0d5424
test
jjyao d0a9562
up
jjyao 741332c
lint
jjyao 6908a2c
fix
jjyao 7e6a480
lint
jjyao 2f910ec
up
jjyao f306a66
test
jjyao 19e8ad7
Revert "test"
jjyao 2979edb
fix
jjyao 27e8ad1
Merge branch 'master' of github.com:ray-project/ray into jjyao/api
jjyao c9b66e4
warn
jjyao 203241f
try
jjyao db0261d
comments
jjyao beb1bf2
up
jjyao e241183
up
jjyao 019fc85
try
jjyao a24f3ba
up
jjyao 7f1b7ae
Revert "try"
jjyao b7b6b5a
try
jjyao d915e3b
try
jjyao 16b0d82
Merge branch 'master' of github.com:ray-project/ray into jjyao/api
jjyao fe9f44d
fix
jjyao 2387859
fix
jjyao a6d319b
reduce time
jjyao 87d6710
fix
jjyao 1272e72
fix
jjyao 11333ba
reduce doc build time
jjyao bd2878e
Merge branch 'master' of github.com:ray-project/ray into jjyao/api
jjyao b80c383
try
jjyao 2b78440
Revert "try"
jjyao ba4ca5e
up
jjyao a855a0a
up
jjyao 166cdf7
Merge branch 'master' of github.com:ray-project/ray into jjyao/api
jjyao 30cf81c
fix
jjyao 8a29670
split
jjyao bba82cf
up
jjyao 7a95a67
split
jjyao 575a8dc
func
jjyao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
{{ fullname | escape | underline}} | ||
|
||
.. currentmodule:: {{ module }} | ||
|
||
.. autoclass:: {{ objname }} | ||
|
||
{% block methods %} | ||
{% if methods %} | ||
.. rubric:: {{ _('Methods') }} | ||
|
||
.. autosummary:: | ||
:toctree: | ||
|
||
{% for item in methods %} | ||
{{ name }}.{{ item }} | ||
{%- endfor %} | ||
|
||
{% endif %} | ||
{% endblock %} | ||
|
||
{% block attributes %} | ||
{% if attributes %} | ||
.. rubric:: {{ _('Attributes') }} | ||
|
||
.. autosummary:: | ||
:toctree: | ||
|
||
{% for item in attributes %} | ||
{{ name }}.{{ item }} | ||
{%- endfor %} | ||
|
||
{% endif %} | ||
{% endblock %} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will generate stub page for each class method and attribute which will make the doc build even longer but that's what other libraries (e.g. pandas, numpy) are doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @maxpumperla FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjyao is there a compromise we could find here? this seems to more than double the build time now. I'm in touch with support from readthedocs.org right now to make longer builds happen, but for now we can't pull this off.
just asking if we can think of a trade-off and move towards a more extensive solution later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can try to not autosummary class members
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, let's try this for now and see how it impacts build times. this PR increases rtd builds from 900s to 2000+, which will always time out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that doesn't work: https://buildkite.com/ray-project/oss-ci-build-pr/builds/11774#01863776-7701-40d6-974c-b6fe51e9d705 since we have places that manually autosummary class members which creates duplications with autoclass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so be it. we just have to make sure we stay below 3000s total, once all other libs merge their changes. might be risky.