-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build_base] [Docker] Add cuda 11.8 images #32247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
ArturNiederfahrenhorst
requested review from
amogkam,
krfricke and
a team
as code owners
February 6, 2023 21:49
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
krfricke
requested changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's update the default cuda version and also add this for ARM64
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
krfricke
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM let's see what the build says
krfricke
changed the title
[Docker] Add cuda 11.8 images
[build_base] [Docker] Add cuda 11.8 images
Feb 7, 2023
Signed-off-by: Kai Fricke <kai@anyscale.com>
krfricke
pushed a commit
to krfricke/ray
that referenced
this pull request
Feb 8, 2023
In order to keep up CUDA versions need for PyTorch 2.0, this PR adds a CUDA 11.8 image. Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: Kai Fricke <kai@anyscale.com>
cadedaniel
pushed a commit
that referenced
this pull request
Feb 8, 2023
* [build_base] [Docker] Add cuda 11.8 images (#32247) In order to keep up CUDA versions need for PyTorch 2.0, this PR adds a CUDA 11.8 image. Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: Kai Fricke <kai@anyscale.com> * Revert default image changes Signed-off-by: Kai Fricke <kai@anyscale.com> --------- Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: Artur Niederfahrenhorst <artur@anyscale.com>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
In order to keep up CUDA versions need for PyTorch 2.0, this PR adds a CUDA 11.8 image. Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com> Signed-off-by: Kai Fricke <kai@anyscale.com> Co-authored-by: Kai Fricke <kai@anyscale.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst artur@anyscale.com
Why are these changes needed?
In order to keep up CUDA versions need for PyTorch 2.0, this PR adds a CUDA 11.8 image.