Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build_base] [Docker] Add cuda 11.8 images #32247

Merged
merged 6 commits into from
Feb 7, 2023

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

Signed-off-by: Artur Niederfahrenhorst artur@anyscale.com

Why are these changes needed?

In order to keep up CUDA versions need for PyTorch 2.0, this PR adds a CUDA 11.8 image.

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's update the default cuda version and also add this for ARM64

ci/build/build-docker-images.py Show resolved Hide resolved
.buildkite/pipeline.build.yml Show resolved Hide resolved
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's see what the build says

@krfricke krfricke changed the title [Docker] Add cuda 11.8 images [build_base] [Docker] Add cuda 11.8 images Feb 7, 2023
@krfricke krfricke merged commit 9995599 into ray-project:master Feb 7, 2023
krfricke pushed a commit to krfricke/ray that referenced this pull request Feb 8, 2023
In order to keep up CUDA versions need for PyTorch 2.0, this PR adds a CUDA 11.8 image.

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Co-authored-by: Kai Fricke <kai@anyscale.com>
cadedaniel pushed a commit that referenced this pull request Feb 8, 2023
* [build_base] [Docker] Add cuda 11.8 images (#32247)

In order to keep up CUDA versions need for PyTorch 2.0, this PR adds a CUDA 11.8 image.

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Co-authored-by: Kai Fricke <kai@anyscale.com>

* Revert default image changes

Signed-off-by: Kai Fricke <kai@anyscale.com>

---------

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Co-authored-by: Artur Niederfahrenhorst <artur@anyscale.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
In order to keep up CUDA versions need for PyTorch 2.0, this PR adds a CUDA 11.8 image.

Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Co-authored-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants