[Data] Add rule for ReorderRandomizeBlockOrder
#32254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogkam
requested review from
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
Signed-off-by: amogkam <amogkamsetty@yahoo.com>
c21
reviewed
Feb 9, 2023
c21
reviewed
Feb 9, 2023
| return LogicalPlan(dag=optimized_dag) | ||
|
|
||
| def _apply(self, op: LogicalOperator) -> LogicalOperator: | ||
| seeds = [] |
There was a problem hiding this comment.
as discussed, let's keep a list of RandomizeBlocks operator, instead of seed, to be future-proof when we add more attributes into RandomizeBlocks. Thanks.
amogkam
changed the title
RandomizeBlockOrderReorderRandomizeBlockOrder
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Ports over previous rule to move RandomizeBlockOrder to the end of a DAG into the new execution backend as an optimizer rule. Closes ray-project#31894 Signed-off-by: amogkam <amogkamsetty@yahoo.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports over previous rule to move
RandomizeBlockOrderto the end of a DAG into the new execution backend as an optimizer rule.Closes #31894
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.