Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3][Docs] Refactor Ray Workflows API documentation (cherry-pick #32248 into 2.3.0 branch) #32275

Merged
merged 1 commit into from
Feb 7, 2023
Merged

[2.3][Docs] Refactor Ray Workflows API documentation (cherry-pick #32248 into 2.3.0 branch) #32275

merged 1 commit into from
Feb 7, 2023

Conversation

c21
Copy link
Contributor

@c21 c21 commented Feb 7, 2023 •
edited
Loading

Why are these changes needed?

Cherry pick #32248 to releases/2.3.0.

Related issue number

Checks

  • [] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@cadedaniel
Copy link
Member

LGTM. @zhe-thoughts @richardliaw approval please

zhe-thoughts
zhe-thoughts approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for cherry picking to 2.3. But someone from the ray-docs group should approve before we merge to master (and then cherry pick)

@c21
Copy link
Contributor Author

c21 commented Feb 7, 2023

@zhe-thoughts - the original PR was approved by ray-docs actually - #32248 .

@zhe-thoughts zhe-thoughts changed the title [2.3][Docs] Refactor Ray Workflows API documentation [2.3][Docs] Refactor Ray Workflows API documentation (cherry-pick #32248 into 2.3.0 branch) Feb 7, 2023
@zhe-thoughts
Copy link
Collaborator

OK then sounds good to pick. Thanks!

@cadedaniel cadedaniel merged commit 860335b into ray-project:releases/2.3.0 Feb 7, 2023
@c21 c21 deleted the cherry-pick-1 branch February 7, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@cadedaniel cadedaniel cadedaniel approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@fishbone fishbone Awaiting requested review from fishbone

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@suquark suquark Awaiting requested review from suquark suquark is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@cadedaniel cadedaniel

@richardliaw richardliaw

@zhe-thoughts zhe-thoughts

@fishbone fishbone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@c21 @cadedaniel @zhe-thoughts @richardliaw @fishbone