Fix overview page to work with the new DASHBOARD_UID env var #32279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Guo <aguo@anyscale.com>
rkooo567
approved these changes
Feb 7, 2023
|
Let's make sure to do one last manual testing after merging this PR! |
+1 Testing End to end! |
alanwguo
added a commit
to alanwguo/ray
that referenced
this pull request
Feb 7, 2023
…ject#32279) In ray-project#32255 , i added a new env var to customize grafana dashboard uid. I forgot to use this var in the overview page. I also made the "View in Grafana" button take the user directly to the dashboard instead of the homepage of Grafana. Signed-off-by: Alan Guo aguo@anyscale.com
cadedaniel
pushed a commit
that referenced
this pull request
Feb 9, 2023
… ray (#32270) * Allow overriding the UID of the default grafana dashboard exported by ray (#32255) Signed-off-by: Alan Guo <aguo@anyscale.com> This lets users with their own grafana setups to have multiple dashboards, one per ray instance. Without this change, each dashboard would have the same uid and replace each other in the grafana DB. * Fix overview page to work with the new DASHBOARD_UID env var (#32279) In #32255 , i added a new env var to customize grafana dashboard uid. I forgot to use this var in the overview page. I also made the "View in Grafana" button take the user directly to the dashboard instead of the homepage of Grafana. Signed-off-by: Alan Guo aguo@anyscale.com --------- Signed-off-by: Alan Guo aguo@anyscale.com
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…ject#32279) In ray-project#32255 , i added a new env var to customize grafana dashboard uid. I forgot to use this var in the overview page. I also made the "View in Grafana" button take the user directly to the dashboard instead of the homepage of Grafana. Signed-off-by: Alan Guo aguo@anyscale.com Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #32255 , i added a new env var to customize grafana dashboard uid. I forgot to use this var in the overview page.
I also made the "View in Grafana" button take the user directly to the dashboard instead of the homepage of Grafana.
Signed-off-by: Alan Guo aguo@anyscale.com
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.