[Flaky release test] Increase timeout of stress_test_many_tasks to ensure perf metrics are available #32286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
approved these changes
Feb 8, 2023
cadedaniel
added a commit
to cadedaniel/ray
that referenced
this pull request
Feb 8, 2023
scv119
pushed a commit
that referenced
this pull request
Feb 8, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
… available (ray-project#32286) Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch_release_logs does not yield any perf metrics for
stress_test_many_tasksbecause it hasn't passed for a few consecutive runs. It hasn't passed because it simply times out. I am doubling the timeout as we should catch regressions by tracking metrics, not by the test failing.I plan on cherry-picking this into 2.3.0 so we can get perf numbers.