Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]Fix wording of Many model training guidance #32319

Merged
merged 6 commits into from
Feb 9, 2023
Merged

[docs]Fix wording of Many model training guidance #32319

merged 6 commits into from
Feb 9, 2023

Conversation

Wendi-anyscale
Copy link
Contributor

Why are these changes needed?

Fix wording

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Wendi-anyscale Wendi-anyscale added the docs An issue or change related to documentation label Feb 8, 2023
@Wendi-anyscale Wendi-anyscale requested a review from a team as a code owner February 8, 2023 18:32
Wendi-anyscale and others added 2 commits February 8, 2023 12:33
@Wendi-anyscale @richardliaw
Update doc/source/ray-overview/use-cases.rst
06652aa 
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Signed-off-by: Wendi-anyscale <97252176+Wendi-anyscale@users.noreply.github.com>
@Wendi-anyscale @richardliaw
Update doc/source/ray-overview/use-cases.rst
f3a68f2 
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Signed-off-by: Wendi-anyscale <97252176+Wendi-anyscale@users.noreply.github.com>
cadedaniel
cadedaniel approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@cadedaniel cadedaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar nits

@richardliaw @cadedaniel
Apply suggestions from code review
1b9b0be 
Co-authored-by: Cade Daniel <cade@anyscale.com>
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
@Wendi-anyscale @cadedaniel
Update doc/source/ray-overview/use-cases.rst
d09348f 
Co-authored-by: Cade Daniel <cade@anyscale.com>
Signed-off-by: Wendi-anyscale <97252176+Wendi-anyscale@users.noreply.github.com>
@richardliaw richardliaw merged commit 8bf1d03 into master Feb 9, 2023
@richardliaw richardliaw deleted the Wendi's-branch branch February 9, 2023 21:39
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@Wendi-anyscale @richardliaw
@cadedaniel @edoakes
[docs]Fix wording of Many model training guidance (ray-project#32319)
a1e1fdd 
Co-authored-by: Richard Liaw <rliaw@berkeley.edu>
Co-authored-by: Cade Daniel <cade@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cadedaniel cadedaniel cadedaniel approved these changes

@richardliaw richardliaw richardliaw approved these changes

Assignees
No one assigned
Labels
docs An issue or change related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wendi-anyscale @cadedaniel @richardliaw