Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Train] Fix use_gpu with HuggingFacePredictor #32333

Merged
merged 6 commits into from
Feb 10, 2023
Merged

[Train] Fix use_gpu with HuggingFacePredictor #32333

merged 6 commits into from
Feb 10, 2023

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Feb 8, 2023 •
edited
Loading

Signed-off-by: Antoni Baum antoni.baum@protonmail.com

Why are these changes needed?

HuggingFacePredictor's use_gpu was set in the wrong method, causing it to not really work correctly. This PR fixes that.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1
[Train] Fix use_gpu with HuggingFacePredictor
106866b 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Fix test
0a8749a 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1 Yard1 requested a review from amogkam February 9, 2023 01:11
@Yard1
Fix test
7ea542e 
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
@Yard1
Merge branch 'hf_predictor_fix_use_gpu' of https://github.com/Yard1/ray…
e30da34 
… into hf_predictor_fix_use_gpu
@Yard1 Yard1 requested a review from amogkam February 9, 2023 20:11
amogkam
amogkam approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amogkam
Copy link
Contributor

amogkam commented Feb 10, 2023

looks like test is failing @Yard1?

@Yard1
Copy link
Member Author

Yard1 commented Feb 10, 2023

It looks unrelated, I reran it. The test I modified is passing

@amogkam amogkam merged commit a1938c3 into ray-project:master Feb 10, 2023
@Yard1 Yard1 deleted the hf_predictor_fix_use_gpu branch February 10, 2023 04:03
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@Yard1 @edoakes
[Train] Fix use_gpu with HuggingFacePredictor (ray-project#32333)
6c96901 
HuggingFacePredictor's use_gpu was set in the wrong method, causing it to not really work correctly. This PR fixes that.

Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

Assignees

@amogkam amogkam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yard1 @amogkam