Cherry pick "[core][state] Task backend improve performance #32251" #32379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rickyyx <rickyx@anyscale.com> This PR aims to improve performance of the task backend with 3 changes: Delay conversion of protobuf. We found the protobuf conversion, especially from TaskSpecification to TaskInfoEntry that's needed for the task metadata has been slow, and was in the critical path of task execution and submission. This PR delays the generation of rpc::TaskEvnets before sending in the flush thread. During task execution, it will simply generate a TaskEvent entry that's in-memory with a lower overhead. Fixed the circular buffer that's used as the underlying data structures for the buffered events. This prevents constant resizing when the buffer gets filled up or flushed, which is costly. Adjust the niceness of the flushing thread, so it has a lower priority than the worker thread.
rickyyx
approved these changes
Feb 9, 2023
zhe-thoughts
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #32251
Release blocker #32235