[Tune] Update trainable remote_checkpoint_dir upon actor reuse
#32420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…/actor_reuse_with_upload_dir
…/actor_reuse_with_upload_dir
…/actor_reuse_with_upload_dir
krfricke
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
This looks good, running cloud release tests to be sure this works: https://buildkite.com/ray-project/release-tests-pr/builds/28382
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…-project#32420) This PR fixes trainable actor reuse to update the remote trial directory that it's writing checkpoints to. Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…-project#32420) This PR fixes trainable actor reuse to update the remote trial directory that it's writing checkpoints to. Signed-off-by: Justin Yu <justinvyu@berkeley.edu> Signed-off-by: elliottower <elliot@elliottower.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes trainable actor reuse to update the remote trial directory that it's writing checkpoints to.
Problem
When using reuse_actors with cloud checkpointing,
Trainable.remote_checkpoint_diris the remote trial directory where it should upload. When trial B swaps with trial A on this actor, theremote_checkpoint_dirdoesn't get updated, so the trainable will continue writing to trial A's remote dir.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.