Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Added test version of BC algorithm based on RLModules an RLTrainers #32471

Merged
merged 15 commits into from
Feb 13, 2023
Merged

[RLlib] Added test version of BC algorithm based on RLModules an RLTrainers #32471

merged 15 commits into from
Feb 13, 2023

Conversation

kouroshHakha
Copy link
Contributor

Why are these changes needed?

This adds a test version of behavioral clonning algorithm so that it can be unittested without relying on more complex algorithms for unittesting (like ppo)

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kouroshHakha
wip
e7425b8 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
Merge branch 'master' into use_rl_module_specs
a5d3d00
@kouroshHakha
added an example bc module for multi-agent that shares encoder
fb4dce0 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
lint
6c80a5b 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
wip
e38980c 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
wip
59a3356 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
BUILD
e7037ce 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
wip
8d34519 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
Merge branch 'master' into bc-trainer-for-test
2f36a62 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
lint
04fec76 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
updated BUILD
9ec1ef8 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
hidden_dims -> fcnet_hiddens
fce2924 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
wip
09867da 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
wip
20969ba 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@kouroshHakha
wip
334450a 
Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
@gjoliver gjoliver merged commit 4ffa7fd into ray-project:master Feb 13, 2023
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@kouroshHakha @edoakes
[RLlib] Added test version of BC algorithm based on RLModules an RLTr…
7a6ad1f 
…ainers (ray-project#32471)

Signed-off-by: Kourosh Hakhamaneshi <kourosh@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnishn avnishn avnishn approved these changes

@gjoliver gjoliver gjoliver approved these changes

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@gjoliver gjoliver

@avnishn avnishn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kouroshHakha @gjoliver @avnishn