[RLlib] Add sample timer to all algorithms where it's simple to add #32475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <artur@anyscale.com>
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
sven1977
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
LGTM. Thanks for the stats-enhancement @ArturNiederfahrenhorst ! :)
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
… (where it's simple to add). (ray-project#32475) Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst artur@anyscale.com
Why are these changes needed?
Many of our algorithms don't offer the SAMPLE_TIMER.
There is no reason why we should offer this is some algorithms and not in others.
This PRs makes it so that all algorithms where it's straightforward to add have it added.
Related issue number
Closes #25914