Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Fix two tests after structure refactor deprecation #32517

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

krfricke
Copy link
Contributor

Signed-off-by: Kai Fricke coding@kaifricke.com

Why are these changes needed?

#32486 introduced two test failures after hard-depracting a structure refactor. This PR fixes these two stale imports.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Kai Fricke <coding@kaifricke.com>
@krfricke krfricke merged commit d092b12 into ray-project:master Feb 14, 2023
@krfricke krfricke deleted the tune/structure-deprec-fix branch February 14, 2023 17:00
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…t#32517)

ray-project#32486 introduced two test failures after hard-depracting a structure refactor. This PR fixes these two stale imports.

Signed-off-by: Kai Fricke <coding@kaifricke.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
…t#32517)

ray-project#32486 introduced two test failures after hard-depracting a structure refactor. This PR fixes these two stale imports.

Signed-off-by: Kai Fricke <coding@kaifricke.com>
Signed-off-by: elliottower <elliot@elliottower.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants