Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake test_dataset.py: split tensor tests #32540

Merged
merged 43 commits into from
Mar 1, 2023

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Feb 14, 2023

Why are these changes needed?

One of the flakiness of test_dataset.py is due to the timeout. This splits out the tensor tests from this big test file.

#32067

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: jianoaix <iamjianxiao@gmail.com>
@jianoaix jianoaix assigned clarkzinzow and unassigned jianoaix Feb 14, 2023
@ericl
Copy link
Contributor

ericl commented Feb 23, 2023

Need to re-run with master merged? Some bazel version error.

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 23, 2023
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jianoaix
Copy link
Contributor Author

Need to re-run with master merged? Some bazel version error.

It seems weird to have Bazel issue as this PR has no change related to that.

@c21
Copy link
Contributor

c21 commented Feb 28, 2023

@jianoaix can we rebase and retrigger the CI? thanks.

@jianoaix
Copy link
Contributor Author

@jianoaix can we rebase and retrigger the CI? thanks.

@jianoaix can we rebase and retrigger the CI? thanks.

Is this issue fixed somewhere now?

@jianoaix jianoaix added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Feb 28, 2023
@ericl ericl merged commit 371b330 into ray-project:master Mar 1, 2023
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
One of the flakiness of test_dataset.py is due to the timeout. This splits out the tensor tests from this big test file.

ray-project#32067
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
One of the flakiness of test_dataset.py is due to the timeout. This splits out the tensor tests from this big test file.

ray-project#32067
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
One of the flakiness of test_dataset.py is due to the timeout. This splits out the tensor tests from this big test file.

ray-project#32067
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
One of the flakiness of test_dataset.py is due to the timeout. This splits out the tensor tests from this big test file.

ray-project#32067
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
One of the flakiness of test_dataset.py is due to the timeout. This splits out the tensor tests from this big test file.

ray-project#32067
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants