Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick doc PRs #34614 #34615 #34435 #34505 #34617 #34623 #34660 #34676

Merged
merged 7 commits into from
Apr 21, 2023

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Apr 21, 2023

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

angelinalg and others added 7 commits April 21, 2023 13:02
Surface LLM/Generative AI use cases.

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Follow up to #34614

Why are these changes needed?
To match the other use cases, we need a more substantial intro paragraph and graphic.

---------

Signed-off-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Co-authored-by: Philipp Moritz <pcmoritz@gmail.com>
One line fix for bug introduced in #34435

Signed-off-by: Kai Fricke <kai@anyscale.com>
A few folks have been confused by the order of the installation instructions for M1, so adding some clarifying language. While I was at it, I made minor improvements to some language in nearby paragraphs.
….py (#34617)

Copy and paste button was including line numbers in 3 code examples, which is a bad user experience. 
Fixed error with filename. The command line instructions said `python model.py` but it should be `python summary_model.py`.

This addresses two issues in GH issue 34481, but not all of them.

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    - [ ] I've added any new APIs to the API Reference. For example, if I added a 
           method in Tune, I've added it in `doc/source/tune/api/` under the 
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjyao jjyao merged commit 4479f66 into releases/2.4.0 Apr 21, 2023
@jjyao jjyao deleted the jjyao/pick branch April 21, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants