Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker] Publish installed packages in docker containers #35390

Merged
merged 3 commits into from
May 19, 2023

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented May 16, 2023

Why are these changes needed?

This PR adds information about the installed packages in our Docker images to the Ray docs.

https://anyscale-ray--35390.com.readthedocs.build/en/35390/ray-overview/installation.html#docker-source-images

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Kai Fricke added 3 commits May 16, 2023 16:29
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
@krfricke krfricke requested a review from richardliaw May 16, 2023 17:51
@krfricke krfricke marked this pull request as ready for review May 16, 2023 17:51
@krfricke krfricke requested a review from a team as a code owner May 16, 2023 17:51
@@ -495,3 +495,27 @@ that you've cloned the git repository.
.. code-block:: bash

python -m pytest -v python/ray/tests/test_mini.py


Installed Python dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How frequently should this be updated? Should the release manager be updating this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the release manager should update it while preparing a release (for the latest documentation). I can add this to the release process doc.

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(approval conditional on release process)

@krfricke krfricke merged commit 17f2319 into ray-project:master May 19, 2023
@krfricke krfricke deleted the docs/installed-packages branch May 19, 2023 12:48
@krfricke
Copy link
Contributor Author

(added to release docs)

ArturNiederfahrenhorst pushed a commit to ArturNiederfahrenhorst/ray that referenced this pull request Jun 8, 2023
…#35390)

This PR adds information about the installed packages in our Docker images to the Ray docs.

Signed-off-by: Kai Fricke <kai@anyscale.com>
scv119 pushed a commit to scv119/ray that referenced this pull request Jun 16, 2023
…#35390)

This PR adds information about the installed packages in our Docker images to the Ray docs.

Signed-off-by: Kai Fricke <kai@anyscale.com>
ArturNiederfahrenhorst added a commit that referenced this pull request Jun 22, 2023
…6229)

* [docker] Publish installed packages in docker containers (#35390)

This PR adds information about the installed packages in our Docker images to the Ray docs.

Signed-off-by: Kai Fricke <kai@anyscale.com>

* Update for green wheels deps

Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>

* Fix versions to 2.5.1

Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>

---------

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Artur Niederfahrenhorst <attaismyname@googlemail.com>
Co-authored-by: Kai Fricke <krfricke@users.noreply.github.com>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
…#35390)

This PR adds information about the installed packages in our Docker images to the Ray docs.

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants