[cherry-pick][core] Retry failed redis request (#35249) #35481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Why are these changes needed? <!-- Please give a short summary of the change and the problem this solves. --> After ray-project#35123 the request in ray is serialized and we should be able to retry the failed redis request in ray. This PR refactor the RedisContext a little bit by remove the CallbackItem and introduce the RequestContext. In side the RequestContext, the failed request will be retried automatically. If still failed in the end, it'll just crash. ## Related issue number ray-project#34014
zhe-thoughts
approved these changes
May 18, 2023
architkulkarni
added a commit
to architkulkarni/ray
that referenced
this pull request
May 19, 2023
…oject#35481)" This reverts commit 64e4926.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This cherry-picks #35249
After #35123 the request in ray is serialized and we should be able to retry the failed redis request in ray.
This PR refactor the RedisContext a little bit by remove the CallbackItem and introduce the RequestContext. In side the RequestContext, the failed request will be retried automatically.
If still failed in the end, it'll just crash.
Related issue number
#34014
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.