Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Fix object detection doc test failures #35528

Merged
merged 1 commit into from
May 22, 2023

Conversation

sihanwang41
Copy link
Contributor

@sihanwang41 sihanwang41 commented May 18, 2023

Why are these changes needed?

image

Not sure what changes (maybe because of some deps changes), straightforward fix.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sihanwang41 <sihanwang41@gmail.com>
@sihanwang41 sihanwang41 marked this pull request as ready for review May 19, 2023 03:22
@ArturNiederfahrenhorst
Copy link
Contributor

@rkooo567 @zcin After this is picked into master, could one of you prepare a cherry pick and enter it into https://docs.google.com/spreadsheets/d/1RL1SjsPrmme5AWRwGPAKFRtjWSkjumIvjpk3zxtJTyM/edit#gid=0
? That would be great 😃

@sihanwang41
Copy link
Contributor Author

Hi @edoakes @architkulkarni , can you help to merge this? thank you!

@edoakes edoakes merged commit decc28d into ray-project:master May 22, 2023
sihanwang41 added a commit to sihanwang41/ray that referenced this pull request May 22, 2023
<img width="1135" alt="image" src="https://github.com/ray-project/ray/assets/6515354/1c9e2cb4-d911-493b-b764-639299da1554">

Not sure what changes (maybe because of  some deps changes), straightforward fix.
ArturNiederfahrenhorst pushed a commit that referenced this pull request May 22, 2023
<img width="1135" alt="image" src="https://github.com/ray-project/ray/assets/6515354/1c9e2cb4-d911-493b-b764-639299da1554">

Not sure what changes (maybe because of  some deps changes), straightforward fix.
scv119 pushed a commit to scv119/ray that referenced this pull request Jun 16, 2023
<img width="1135" alt="image" src="https://github.com/ray-project/ray/assets/6515354/1c9e2cb4-d911-493b-b764-639299da1554">

Not sure what changes (maybe because of  some deps changes), straightforward fix.
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
<img width="1135" alt="image" src="https://github.com/ray-project/ray/assets/6515354/1c9e2cb4-d911-493b-b764-639299da1554">

Not sure what changes (maybe because of  some deps changes), straightforward fix.

Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants