[CI] Skip test_multiprocessing_client_mode on windows
#35534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
|
Once this is merged we can open another issue to un-skip this test (Or @can-anyscale , let me know if there's a better process to follow here) |
rkooo567
approved these changes
May 18, 2023
|
This is obviously red on the 2.5.0 branch and we would like to have green tests there. |
cadedaniel
approved these changes
May 19, 2023
|
Test failures unrelated, this PR just skips a test on Windows and the WIndows tests passed. |
architkulkarni
added
the
tests-ok
architkulkarni
added a commit
to architkulkarni/ray
that referenced
this pull request
May 19, 2023
…35534) test_multiprocessing_client_mode is very flaky on Windows. This PR skips it on Windows. Related issue number Closes ray-project#35526 Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
8 tasks
ArturNiederfahrenhorst
pushed a commit
that referenced
this pull request
May 19, 2023
) test_multiprocessing_client_mode is very flaky on Windows. This PR skips it on Windows. Related issue number Closes #35526 Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
…35534) test_multiprocessing_client_mode is very flaky on Windows. This PR skips it on Windows. Related issue number Closes ray-project#35526 Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…35534) test_multiprocessing_client_mode is very flaky on Windows. This PR skips it on Windows. Related issue number Closes ray-project#35526 Signed-off-by: Archit Kulkarni <architkulkarni@users.noreply.github.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
8 tasks
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
After PR ray-project#35526 the test_multiprocessing_client_mode test became flaky on windows. It was skipped in ray-project#35534. Let's see if it passes now Signed-off-by: mattip <matti.picus@gmail.com> Co-authored-by: Archit Kulkarni <architkulkarni@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This test is very flaky on Windows. This PR skips it on Windows.
Related issue number
Closes #35526
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.