Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick] [RLlib, RLlib contrib] add soft deprecation notices to maml and a3c #35564

Merged
merged 1 commit into from
May 21, 2023

Conversation

avnishn
Copy link
Member

@avnishn avnishn commented May 19, 2023

#35345)

Cherry picking some deprecation notices for the 2.5 release

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@zhe-thoughts
Copy link
Collaborator

@avnishn could you link the original PR that you are cherry picking from? Thanks

@avnishn
Copy link
Member Author

avnishn commented May 19, 2023

sure @zhe-thoughts
#35345

@zhe-thoughts
Copy link
Collaborator

Thanks @avnishn . Approved. I'm updating the PR title to match the master PR

@zhe-thoughts zhe-thoughts changed the title [Cherry-pick]Cherry pick a3c maml deprecation [Cherry-pick] [RLlib, RLlib contrib] add soft deprecation notices to maml and a3c May 19, 2023
@avnishn avnishn merged commit 1bc1ecc into releases/2.5.0 May 21, 2023
@avnishn avnishn deleted the cherry_pick_a3c_maml_deprecation branch May 21, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants