Separate computer_vision.py into its own test of enormous size. #35616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good. the separated test passed: |
matthewdeng
reviewed
May 22, 2023
doc/BUILD
Outdated
| main = "source/ray-air/doc_code/computer_vision.py", | ||
| srcs = ["source/ray-air/doc_code/computer_vision.py"], | ||
| tags = ["exclusive", "team:ml"], | ||
| size = "enormous", |
There was a problem hiding this comment.
Should this be large? Since it finishes in 566 < 900 secs.
Suggested change
| size = "enormous", | |
| size = "large", |
There was a problem hiding this comment.
apparently it runs faster once I separated it out.
it was timing out consistently at 900s.
There was a problem hiding this comment.
I thought we were supposed to avoid using the 'enormous' tag?
There was a problem hiding this comment.
😕
so the options are splitting the actual script into 2.
or specify a different more specific limit?
do you have a preference?
added 4 commits
May 23, 2023 12:16
Signed-off-by: Jun Gong <jungong@anyscale.com>
Signed-off-by: Jun Gong <jungong@anyscale.com>
gjoliver
force-pushed
the
computer_vision_test
branch
from
31c5f67 to
604cbce
Compare
Signed-off-by: Jun Gong <jungong@anyscale.com>
richardliaw
approved these changes
May 23, 2023
gjoliver
pushed a commit
to gjoliver/ray
that referenced
this pull request
May 24, 2023
…size. (ray-project#35616) Signed-off-by: Jun Gong <jungong@anyscale.com>
scv119
pushed a commit
to scv119/ray
that referenced
this pull request
Jun 16, 2023
…size. (ray-project#35616) Signed-off-by: Jun Gong <jungong@anyscale.com>
arvind-chandra
pushed a commit
to lmco/ray
that referenced
this pull request
Aug 31, 2023
…size. (ray-project#35616) Signed-off-by: Jun Gong <jungong@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This test is too long.
Separate it into a different test.
Related issue number
Issue #35551
Issue #35692
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.