-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Use Ray fork of pytest-sphinx
#35927
Conversation
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
I assume we don't want to maintain pytest-sphinx. Do we have plan to merge these features to the main pytest-sphinx sometimes soon? |
Yeah, I have a PR open: twmr/pytest-sphinx#54. Also, the changes are minor (see ray-project/pytest-sphinx#1 and ray-project/pytest-sphinx#2), so the maintenance burden is low anyway. |
Sound good, can we add a TODO or an issue somewhere to follow up and move back to the original pytest-sphinx. |
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
pytest-sphinx lacks: Support for MyST files The ability to mock outputs for illustrative purposes To address these issues, I've forked pytest-sphinx to https://github.com/ray-project/pytest-sphinx and implemented the features. --------- Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
Why are these changes needed?
pytest-sphinx
lacks:To address these issues, I've forked
pytest-sphinx
to https://github.com/ray-project/pytest-sphinx and implemented the features.Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.