Make Ray wheels work on GH200 #40816
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Oct 31, 2023
| # for why we are setting "--with-lg-page" on non x86 hardware here. | ||
| configure_options = ["--disable-static", "--enable-prof"] + | ||
| select({ | ||
| "@platforms//cpu:x86_64": [], |
There was a problem hiding this comment.
don't we needt oset --with-lg-page=12?
There was a problem hiding this comment.
No, the existing behavior is fine (on x86, the page size is the same on all the architectures and it will select that on compilation)
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
|
hmm test_advanced_5 probably related |
|
cc @pcmoritz do you need help taking this issue btw? Or do you think you will have bandwidth to merge it? |
|
Test memory pressure is very flaky and almost certainly unrelated to this PR (since this PR doesn't change anything on x86_64) |
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
Signed-off-by: Philipp Moritz <pcmoritz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This makes sure the Ray Wheels works on nvidia's GH200 (Grace Hopper) architecture.
Fixes #40815
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.