[idle term] fix on local resource idle time check #41206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the timing check is too tight. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-1116-timing
branch
from
fff2007 to
d26ee7c
Compare
|
https://buildkite.com/ray-project/premerge/builds/11954#018bd8cc-885b-4933-9490-7eaaea6b9000/5631-6348 and: |
aslonnie
requested review from
rickyyx and
jjyao
and removed request for
rickyyx
rickyyx
approved these changes
Nov 16, 2023
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Nov 29, 2023
the timing check is too tight. Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the timing check is too tight.