Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more config information to the stable diffusion template and update to 2.9 #41987

Merged
merged 11 commits into from
Jan 2, 2024

Conversation

akshay-anyscale
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
@akshay-anyscale akshay-anyscale changed the title Add more config information to the stable diffusion template Add more config information to the stable diffusion template and update to 2.9 Jan 1, 2024
@@ -5,7 +5,7 @@
| Summary | This app provides users a one click production option for serving a pre-trained Stable Diffusion model from HuggingFace. It leverages [Ray Serve](https://docs.ray.io/en/latest/serve/index.html) to deploy locally and built in IDE integration on an Anyscale Workspace to iterate and add additional logic to the application. You can then use a simple CLI to deploy to production with [Anyscale Services](https://docs.anyscale.com/productionize/services/get-started). |
| Time to Run | Around 2 minutes to setup the models and generate your first image(s). Less than 10 seconds for every subsequent round of image generation (depending on the image size). |
| Minimum Compute Requirements | At least 1 GPU node. The default is 4 nodes, each with 1 NVIDIA T4 GPU. |
| Cluster Environment | This template uses a docker image built on top of the latest Anyscale-provided Ray image using Python 3.9: [`anyscale/ray:latest-py39-cu118`](https://docs.anyscale.com/reference/base-images/overview). See the appendix below for more details. |
| Cluster Environment | This template uses a docker image built on top of the latest Anyscale-provided Ray 2.9 image using Python 3.9: [`anyscale/ray:latest-py39-cu118`](https://docs.anyscale.com/reference/base-images/overview). See the appendix below for more details. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use the py39-cu118 vs anyscale/ray-ml:2.9.0-py39-gpu?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try it out, I believe it was first set up this way because ray-ml has some conflicting dependencies? @matthewdeng @justinvyu ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the anyscale/ray-ml:2.9.0-py39-gpu and installed diffusers, transformers, and accelerate on all nodes. It worked fine when generating images.

Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
@matthewdeng matthewdeng merged commit 923ea82 into master Jan 2, 2024
9 checks passed
@matthewdeng matthewdeng deleted the akshay-anyscale-patch-1 branch January 2, 2024 19:13
vickytsang pushed a commit to ROCm/ray that referenced this pull request Jan 12, 2024
…te to 2.9 (ray-project#41987)

Signed-off-by: akshay-anyscale <122416226+akshay-anyscale@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants