[Docs] Theme revamp: primary sidebar #41998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peytondmurray
changed the title
peytondmurray
force-pushed
the
docs-theme-revamp-primary-sidebar
branch
3 times, most recently
from
2203f7d to
40d28d0
Compare
peytondmurray
added
P1
peytondmurray
force-pushed
the
docs-theme-revamp-primary-sidebar
branch
from
40d28d0 to
7f492d2
Compare
|
Thanks @peytondmurray .
4. Is it possible to increase the spacing between the links in the left nav? Maybe increase the padding to 0.40em (top and bottom)?
|
|
After a discussion on slack for clarification:
|
peytondmurray
force-pushed
the
docs-theme-revamp-primary-sidebar
branch
from
7f492d2 to
a2680eb
Compare
Signed-off-by: pdmurray <peynmurray@gmail.com>
peytondmurray
force-pushed
the
docs-theme-revamp-primary-sidebar
branch
from
a2680eb to
77de818
Compare
|
Hmm, the hover link colors are nearly indistinguishable from standard ray blue, so it will be really hard to perceive any kind of hover color change. Let's revisit the color changes in a separate PR. |
|
lgtm |
|
@maxpumperla If the build looks good to you, would you be able to merge this? |
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
- Added an ::after pseudo-element that gives a splash of color to the main content of the page - Set the max-width of the primary sidebar to 30% for the example gallery; otherwise the primary sidebar grows indefinitely to accommodate the flexbox that holds the tag filter buttons - Set background, text-base, text-muted, and heading CSS color variables for dark and light themes - Removed the empty space on either side of the main article content, allowing articles to expand to the size of the user's browser. This gives us a HUGE increase in screen real estate! - Modify styles of primary sidebar dropdown; highlight the current page in the sidebar - Add the Inter font globally - Added css to the list of filetypes formatted by the prettier pre-commit hook. Also now that pre-commit is in the repo, the hooks ran on these files, causing a bit of reformatting. Signed-off-by: pdmurray <peynmurray@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR implements a number of style changes to the docs to match new designs created by @simran-2797.
Changes
::afterpseudo-element that gives a splash of color to the main content of the pagemax-widthof the primary sidebar to 30% for the example gallery; otherwise the primary sidebar grows indefinitely to accommodate the flexbox that holds the tag filter buttonsInterfont globallyprettierpre-commit hook. Also now that pre-commit is in the repo, the hooks ran on these files, causing a bit of reformatting.Docs splash page:
Related issue number
Closes #41618.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.