fix default workflow_data directory on Windows where /tmp does not exist #42067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masariello
requested review from
ericl,
fishbone,
stephanie-wang and
suquark
as code owners
masariello
requested review from
richardliaw,
krfricke,
xwjiang2010,
amogkam,
matthewdeng,
Yard1,
maxpumperla,
justinvyu,
woshiyyya,
a team,
sven1977,
avnishn,
ArturNiederfahrenhorst,
smorad,
kouroshHakha,
scv119,
c21,
scottjlee,
bveeramani,
raulchen,
Zandew,
aslonnie,
can-anyscale,
architkulkarni and
hongchaodeng
as code owners
aslonnie
removed request for
woshiyyya,
kouroshHakha,
avnishn,
Zandew,
xwjiang2010,
aslonnie,
can-anyscale,
hongchaodeng,
richardliaw,
matthewdeng,
maxpumperla,
justinvyu,
sven1977,
smorad,
c21,
scottjlee,
architkulkarni and
amogkam
Signed-off-by: Masariello <masariello@gmail.com>
jjyao
approved these changes
Jan 8, 2024
fishbone
approved these changes
Jan 10, 2024
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
…does not exist (ray-project#42067) Signed-off-by: Masariello <masariello@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a pretty trivial and readable code change to make the default init work on Windows
Thank you