Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Test] Fix osx tests failures on memory profiling #42081

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Jocn2020
Copy link
Contributor

@Jocn2020 Jocn2020 commented Dec 22, 2023

Why are these changes need

Fix memory profiling osx test since memray is not installed in osx image.
Screen Shot 2023-12-21 at 21 59 19

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jocn2020 <jonathannitisastro@gmail.com>
@Jocn2020 Jocn2020 changed the title [Dashboard][Test] Dix osx tests failures on memory profiling [Dashboard][Test] Fix osx tests failures on memory profiling Dec 22, 2023
@Jocn2020
Copy link
Contributor Author

cc: @jjyao @can-anyscale

@jjyao jjyao merged commit 00d605f into ray-project:master Dec 22, 2023
9 checks passed
vickytsang pushed a commit to ROCm/ray that referenced this pull request Jan 12, 2024
…ject#42081)

Skip memory profiling osx test since memray is not installed in osx image.

Signed-off-by: Jocn2020 <jonathannitisastro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants