Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Unify the handle_request_streaming replica path for gRPC #42143

Merged
merged 3 commits into from
Jan 2, 2024
Merged

[serve] Unify the handle_request_streaming replica path for gRPC #42143

merged 3 commits into from
Jan 2, 2024

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Jan 2, 2024

Why are these changes needed?

Remove custom call_user_method_with_grpc_unary_stream for gRPC (it's only barely different than call_user_method_generator.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes
fix
34a70a2 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested a review from GeneDer January 2, 2024 17:54
edoakes added 2 commits January 2, 2024 12:41
@edoakes
fix
8ad2650 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
Merge branch 'master' of https://github.com/ray-project/ray into unif…
893d70f 
…y-grpc-streaming-path
GeneDer
GeneDer approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@edoakes edoakes merged commit 0ee5a32 into ray-project:master Jan 2, 2024
9 checks passed
vickytsang pushed a commit to ROCm/ray that referenced this pull request Jan 12, 2024
@edoakes @vickytsang
[serve] Unify the handle_request_streaming replica path for gRPC (r…
9de5f74 
…ay-project#42143)

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeneDer GeneDer GeneDer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edoakes @GeneDer