[data] Deflake TestStreamOutputBackpressurePolicy.test_e2e_backpressure #42150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
stephanie-wang and
Zandew
as code owners
scottjlee
reviewed
Jan 2, 2024
| # is scheduled. But there is a delay between the consumer task is scheduled | ||
| # and the consumer task starts to run. Thus the order of | ||
| # producer_timestamps[3] and consumer_timestamps[0] is not deterministic. | ||
| # To avoid flakiness, we check consumer_timestamps[0] < producer_timestamps[4]. |
There was a problem hiding this comment.
@raulchen to confirm my understanding, we are guaranteed that consumer_timestamps[0] < producer_timestamps[4] since block 4 will only be generated after the second consumer task is scheduled, which only occurs after the first consumer task consuming block 3 concludes?
scottjlee
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The test is flakey on slow machines. See comments for details.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.