[serve] Remove aiorwlock dependency
#42159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
changed the title
aiorwlock dependencyaiorwlock dependency
GeneDer
approved these changes
Jan 3, 2024
richardliaw
approved these changes
Jan 9, 2024
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jan 12, 2024
This was added long ago to avoid race conditions between reconfigure and user method calls. However, sometime since then the reader lock acquisition seems to have been accidentally removed. We have not seen any issues from this so my preference is to just altogether remove the complexity & dependency. Users can implement their own coordination if this is a problem for them by adding concurrency control to their reconfigure method. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This was added long ago to avoid race conditions between
reconfigureand user method calls. However, sometime since then the reader lock acquisition seems to have been accidentally removed. We have not seen any issues from this so my preference is to just altogether remove the complexity & dependency.Users can implement their own coordination if this is a problem for them by adding concurrency control to their
reconfiguremethod.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.